fix(newm-admin): Add macOS code signing and notarization#709
Merged
Conversation
AndrewWestberg
force-pushed
the
amw/fix_newm_admin_dmg
branch
from
362c6e3 to
134b914
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds macOS code signing and notarization capabilities to the NEWM Admin release workflow, enabling the app to run on macOS without Gatekeeper warnings. It also introduces universal binary support for both Intel and Apple Silicon Macs.
Changes:
- Implements code signing and notarization workflow with certificate management
- Creates universal (Intel + ARM) binaries using
lipo - Adds entitlements for runtime hardening and network access
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/newm-admin-release.yml |
Adds certificate import, code signing, and notarization steps to macOS packaging job |
newm-admin/packaging/macos/bundle.sh |
Implements universal binary creation and code signing logic with optional signing identity |
newm-admin/packaging/macos/Entitlements.plist |
Defines required entitlements for unsigned executable memory (JIT) and network client access |
newm-admin/Cargo.toml |
Bumps version to 0.1.3-alpha.3 |
newm-admin/Cargo.lock |
Updates lockfile to match new version |
AndrewWestberg
force-pushed
the
amw/fix_newm_admin_dmg
branch
from
ab76be7 to
4ce6ea9
Compare
AndrewWestberg
force-pushed
the
amw/fix_newm_admin_dmg
branch
from
4ce6ea9 to
a6c12a5
Compare
AndrewWestberg
force-pushed
the
amw/fix_newm_admin_dmg
branch
from
a6c12a5 to
3f05f94
Compare
Comment on lines
+150
to
+151
| # Decode certificate | ||
| echo "$MACOS_CERTIFICATE" | base64 --decode > certificate.p12 |
There was a problem hiding this comment.
The certificate import will fail silently if MACOS_CERTIFICATE is empty or not base64-encoded properly. Add validation to check if the secret is set and is valid base64 before attempting to decode and import it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.