feat: MOBILE-388 - add multi-chain NFT song api#715
Merged
Conversation
2123284 to
ff5fcfd
Compare
|
|
||
| // Temporary test hook until Ethereum wallet connections are implemented | ||
| val email = transaction { UserEntity[userId].email } | ||
| if (!email.endsWith("@newm.io")) return emptyList() |
cristhianescobar
approved these changes
Jan 25, 2026
7700529 to
b7f6d5c
Compare
b7f6d5c to
675feea
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new multi-chain NFT song API that aggregates NFT songs from both Cardano and Ethereum blockchains. The implementation includes Ktor version upgrade to 3.4.0 and adds response compression for the new endpoint.
Changes:
- Adds unified
/v1/nft/songsendpoint combining Cardano and Ethereum NFT songs - Upgrades Ktor from 3.3.3 to 3.4.0 and adds compression plugins (gzip, deflate, zstd)
- Refactors Ethereum repository to accept userId instead of owner address (includes temporary test hook for @newm.io emails)
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| buildSrc/src/main/kotlin/Versions.kt | Updates Ktor version to 3.4.0 |
| buildSrc/src/main/kotlin/Dependencies.kt | Adds Ktor compression and zstd dependencies |
| newm-server/build.gradle.kts | Adds server compression dependencies |
| newm-server/src/main/resources/application.conf | Configures compression for NFT song endpoint |
| newm-server/src/main/kotlin/io/newm/server/compression/CompressionInstall.kt | Implements compression plugin installation |
| newm-server/src/main/kotlin/io/newm/server/Application.kt | Registers compression plugin and NFT song routes |
| newm-server/src/main/kotlin/io/newm/server/features/nftsong/model/*.kt | Defines unified NFT song data models with chain-specific metadata |
| newm-server/src/main/kotlin/io/newm/server/features/nftsong/repo/*.kt | Implements repository aggregating Cardano and Ethereum NFT songs |
| newm-server/src/main/kotlin/io/newm/server/features/nftsong/NftSongRoutes.kt | Adds authenticated GET endpoint for multi-chain NFT songs |
| newm-server/src/main/kotlin/io/newm/server/features/nftsong/NftSongKoinModule.kt | Registers NFT song repository in DI container |
| newm-server/src/main/kotlin/io/newm/server/features/ethereum/repo/*.kt | Changes method signature to use userId and adds temporary test hook |
| newm-server/src/main/kotlin/io/newm/server/features/ethereum/EthereumRoutes.kt | Simplifies route to use userId from auth context |
| newm-server/src/main/kotlin/io/newm/server/features/ethereum/EthereumKoinModule.kt | Adds Ethereum repository registration in DI |
| newm-server/src/main/kotlin/io/newm/server/di/DependencyInjectionInstall.kt | Registers NFT song module |
| newm-server/src/main/kotlin/io/newm/server/features/user/repo/UserRepositoryImpl.kt | Refactors when expression to use subject instead of conditions |
AndrewWestberg
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.