Skip to content

Add a travis file#108

Closed
cgwalters wants to merge 1 commit intoprojectatomic:masterfrom
cgwalters:travis-and-homu
Closed

Add a travis file#108
cgwalters wants to merge 1 commit intoprojectatomic:masterfrom
cgwalters:travis-and-homu

Conversation

@cgwalters
Copy link
Member

My primary goal here is just to enable Homu usage.

My primary goal here is just to enable Homu usage.
@cgwalters
Copy link
Member Author

⚠️ Oops, meant to test this against my fork. @rhvgoyal - don't merge this yet please! ⚠️

@cgwalters
Copy link
Member Author

@cgwalters-bot try

@cgwalters
Copy link
Member Author

@cgwalters-bot retry

@cgwalters-bot
Copy link

⌛ Trying commit 0be34df with merge 245bcb6...

cgwalters-bot pushed a commit that referenced this pull request Mar 16, 2016
My primary goal here is just to enable Homu usage.

Pull request: #108
Approved by: <try>
@cgwalters-bot
Copy link

☀️ Test successful - travis

@cgwalters cgwalters mentioned this pull request Mar 16, 2016
@cgwalters
Copy link
Member Author

@rhvgoyal If you want to try this out, enter in text @ cgwalters-bot r+ 245bcb6 with no space between @ and the name.

@rhvgoyal
Copy link
Collaborator

@cgwalters-bot r+ 245bcb6

@cgwalters-bot
Copy link

🙀 245bcb6 is not a valid commit SHA. Please try again with 0be34df.

@rhvgoyal
Copy link
Collaborator

@cgwalters-bot r+ 0be34df

@cgwalters-bot
Copy link

⌛ Testing commit 0be34df with merge 1141872...

cgwalters-bot pushed a commit that referenced this pull request Mar 16, 2016
My primary goal here is just to enable Homu usage.

Pull request: #108
Approved by: rhvgoyal
@cgwalters-bot
Copy link

☀️ Test successful - travis

@rhvgoyal
Copy link
Collaborator

@cgwalters why did I lose the link to my jenkins test results while I tried to run homu.

@cgwalters
Copy link
Member Author

This is apparently because the PR was closed instead of known to github as merged. See barosl/homu#139

However, I think we can address this somehow. One way would be for the PR tester to add a comment in addition to the status. Another would be for homu to gather all successful links.

In general, an issue right now is we're only gating on travis, but we should probably consistently use the github status. I'll look at that change too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments