Blacklight::OpenStructWithHashAccess should expose a HashWithIndifferentAccess #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
approved these changes
Dec 3, 2016
|
Too bad about all the side-effects, though. I'm not sure it's worth it. It's probably easier just to declare configuration keys are symbols. |
cbeer
force-pushed
the
indifferent-hash-access
branch
3 times, most recently
from
04ab542 to
a8a03ad
Compare
cbeer
force-pushed
the
indifferent-hash-access
branch
from
a8a03ad to
d2bcdef
Compare
|
@cbeer: since we have/had apps using non-symbol keys, is it worth it detect those and warn/fail? Do we need a deprecation release or can we just declare that was always the intent? |
|
Reimplementing on master (or even using HashWithIndifferentAccess) raises errors in presenters around valid keys in the interpolation helpers. I'm going to bump this to 8.x, since it's a more complicated change now than it may have once been. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.