Pass document + presenter through to DocumentMetadataComponent. #3587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Apr 29, 2025
jcoyne
reviewed
Apr 29, 2025
| @@ -9,8 +9,10 @@ class DocumentMetadataComponent < Blacklight::Component | |||
|
|
|||
| # @param fields [Enumerable<Blacklight::FieldPresenter>] Document field presenters | |||
| # rubocop:disable Metrics/ParameterLists | |||
| def initialize(fields: [], tag: 'dl', classes: %w[document-metadata dl-invert row], show: false, view_type: nil, field_layout: nil, **component_args) | |||
| def initialize(fields: [], document: nil, presenter: nil, tag: 'dl', classes: %w[document-metadata dl-invert row], show: false, view_type: nil, field_layout: nil, **component_args) | |||
There was a problem hiding this comment.
Do we need both document + presenter? Wouldn't presenter be sufficient as it's a wrapper around the document and thus we can get the document via presenter.document?
There was a problem hiding this comment.
🤷 we pass both to all the other subcomponents.
cbeer
force-pushed
the
doc-metadata-args
branch
from
e976bdf to
8622844
Compare
|
+1 to this change. I recently found myself having to subclass |
|
This needs #3586 to be merged first I believe. |
cbeer
force-pushed
the
doc-metadata-args
branch
from
8622844 to
ea02c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
DocumentMetadataComponentsimilar to the other document sub-components.