fix(common): flatten Bluefin face icons into /usr/share/pixmaps/faces - #1296
Open
castrojo wants to merge 1 commit into
Open
fix(common): flatten Bluefin face icons into /usr/share/pixmaps/faces#1296castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
common ships the Bluefin user-avatar art (including the dinosaur images) under /usr/share/pixmaps/faces/bluefin/. GNOME's account avatar chooser scans /usr/share/pixmaps/faces non-recursively, so the files landed in the image but never appeared in Settings > Users. Flatten faces/bluefin/* over faces/ in install-commands, matching ublue-os/bluefin build_files/base/05-override-install.sh. The flattened filenames collide with the GNOME OS defaults from core/gnome-control-center.bst, so add /usr/share/pixmaps/faces/* to the overlap-whitelist. Closes projectbluefin#353 Assisted-by: Claude Sonnet 4.6 via goose
Contributor
|
This PR targets |
5 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #353
Problem
projectbluefin/commonships the Bluefin user-avatar art undersystem_files/bluefin/usr/share/pixmaps/faces/bluefin/(15 JPEGs, including thedinosaur images).
elements/bluefin/common.bstcopiessystem_files/bluefin/usr/verbatim, so those files land at
/usr/share/pixmaps/faces/bluefin/in the image— confirmed by
files/fakecap-manifest.tsv:657723-657737, which maps all 15 tobluefin/common.bst.GNOME's account-avatar chooser reads
/usr/share/pixmaps/facesonly, so theimages are present on disk but never offered to users.
ublue-os/bluefinsolvesthis in
build_files/base/05-override-install.sh(lines 29-32) by flatteningfaces/bluefin/*overfaces/at build time; dakota has no equivalent step.Change
elements/bluefin/common.bstinstall-commands: move%{datadir}/pixmaps/faces/bluefin/*into%{datadir}/pixmaps/faces/andremove the now-empty subdirectory, guarded by a
-dtest.overlap-whitelist: add/usr/share/pixmaps/faces/*. Theflattened filenames are identical to the GNOME OS defaults from
core/gnome-control-center.bst(files/fakecap-manifest.tsv:657738-657752),so the overlap is intentional and must be declared.
docs/skills/oci-layers.md: record the vendor-subdirectory pattern.Validation
Not run — this environment has no container runtime (
podman/dockerabsent),so
just bst,just validate,just build,just lint, andjust boot-testall cannot execute here. The change is unverified by build; please treat CI
validate+e2eas the gate.What to check after a build:
Note on generated files:
files/filemap.jsonandfiles/fakecap-manifest.tsvstill list the old
faces/bluefin/*paths. Regenerating them requiresbst artifact list-contentsagainst a populated local cache(
docs/skills/ci.md, "Generated Files"), which is not possible here. They arerefreshed by the monthly
update-filemap.ymlworkflow; a maintainer can runworkflow_dispatchwithforce_regenerateafter merge if an immediate refreshis wanted. Stale entries are non-fatal —
fakecap-restoreskips paths that donot exist (
files/fakecap/fakecap-restore.c:67-73); the effect is only that the15 avatars are unlabelled for chunkah layer assignment until regeneration.