Skip to content

ci(C1): thin caller for reusable-promote workflow - #788

Merged
castrojo merged 2 commits into
mainfrom
ci/c1-thin-caller-test
Jun 11, 2026
Merged

ci(C1): thin caller for reusable-promote workflow#788
castrojo merged 2 commits into
mainfrom
ci/c1-thin-caller-test

Conversation

@castrojo

@castrojo castrojo commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Consistency audit C1: replace the 183-line promote-testing-to-main.yml with a 30-line thin caller to the shared reusable-promote reusable workflow in projectbluefin/actions.

Before: 183-line workflow with full digest resolution, release-state.yaml management, PR creation, gate checks
After: 30-line caller — all logic in projectbluefin/actions/reusable-promote.yml@8487dff # v1

Adoption order (canary-first per consistency audit)

  1. dakota (this PR) — 1 variant pair, lowest user impact ← here
  2. bluefin-lts — observe one promotion cycle
  3. bluefin — highest user impact, land last

Closes automation-audit C1 (partial — canary step).

Assisted-by: Claude Sonnet 4.5 via pi

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@castrojo, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 14 minutes and 36 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5accc911-3321-4007-a81f-e1d11e2c705c

📥 Commits

Reviewing files that changed from the base of the PR and between ba3f131 and 2f33e09.

📒 Files selected for processing (1)
  • .github/workflows/promote-testing-to-main.yml
📝 Walkthrough

Walkthrough

The promote-testing-to-main workflow is refactored from an inline promotion implementation to a thin caller. The ~183-line promotion job is replaced with a delegated call to a reusable workflow, passing variants and cosign_identity_regexp configuration while removing all inlined digest resolution, release-state management, branch handling, and PR creation logic.

Changes

Workflow delegation refactoring

Layer / File(s) Summary
Refactor promote job to reusable workflow delegation
.github/workflows/promote-testing-to-main.yml
The promote job description is updated and the job implementation is replaced with a call to projectbluefin/actions/.github/workflows/reusable-promote.yml, passing variants and cosign_identity_regexp inputs that preserve the original promotion intent while removing ~160 lines of inline digest resolution, release-state management, branch handling, and PR creation steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Possibly related PRs

  • projectbluefin/dakota#757: Both PRs refactor .github/workflows/promote-testing-to-main.yml to delegate its existing digest/release-state/PR-creation logic to a reusable workflow, directly overlapping the same promotion workflow behavior.
  • projectbluefin/dakota#760: Both PRs modify .github/workflows/promote-testing-to-main.yml, with the main PR refactoring its promotion logic into a reusable workflow call while PR #760 adds a scheduled trigger to the same workflow.

Suggested labels

area/ci, kind/improvement

Suggested reviewers

  • p5
  • tulilirockz

Poem

🐰 A workflow once thick with inline code,
Now lighter, cleaner—a reusable road,
Delegation brings order to Dakota's domain,
Promotion flows neat through the action's refrain!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'ci(C1): thin caller for reusable-promote workflow' accurately reflects the main change: refactoring the workflow from inline implementation to a thin caller delegating to a reusable workflow.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/c1-thin-caller-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR! A maintainer will review it.

While you wait, make sure these pass locally:

just validate        # element graph check
just build default   # build the image
just boot-test       # confirm the desktop boots (exits 0 = pass)
just lint            # bootc container lint

If this PR fixes a bug, add verify steps to the linked issue so users can confirm the fix on their hardware after the next nightly ships:

```verify
ujust <something>   # what users should run to confirm the fix
```

@castrojo
castrojo marked this pull request as ready for review June 10, 2026 23:57
@castrojo
castrojo requested review from p5 and tulilirockz as code owners June 10, 2026 23:57
@castrojo castrojo changed the title ci(test): thin caller for reusable-promote consumer validation [DO NOT MERGE] ci(C1): thin caller for reusable-promote workflow Jun 11, 2026
castrojo added 2 commits June 10, 2026 20:15
Draft PR — consumer validation test for projectbluefin/actions#157.
DO NOT MERGE — will be updated to pin the merged SHA after review.

Replaces 183-line promote-testing-to-main.yml with a 30-line caller
to projectbluefin/actions/.github/workflows/reusable-promote.yml.

Assisted-by: Claude Sonnet 4.5 via pi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4-review A pull request is awaiting review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant