Enable systemd-homed support by default - #962
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughA new patch file adds systemd-homed support to the GNOME OS live build: Changessystemd-homed Support Patch
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR targets |
54b27a7 to
73d9f70
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@patches/gnome-build-meta/0003-homed-Add-systemd-homed-support.patch`:
- Around line 113-116: Add proper error handling to the homed configuration
creation code. First, check the return value of the fopen call (which creates
the file at /run/systemd/homed.conf.d/00-force-subvolume.conf) before calling
fprintf on it to prevent NULL pointer dereference. Second, change the mkdir
permissions from 0777 to 0755 for more restrictive directory permissions, and
check the mkdir return value to handle EEXIST errors for idempotency (this
allows the code to work if the directory already exists). Additionally, include
the errno.h header to enable proper error checking utilities for these system
calls.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b5c89439-14e8-44b8-9ecf-1a76ddb07951
📒 Files selected for processing (1)
patches/gnome-build-meta/0003-homed-Add-systemd-homed-support.patch
|
Hey @dylanmtaylor — sorry for the noise here. The Your actual contribution is exactly one file ( I've opened #964 which is a cherry-pick of your patch onto the current This PR (#962) can be closed in favour of #964. Thanks for the contribution! |
|
This PR targets |
|
This PR targets |
hanthor
left a comment
There was a problem hiding this comment.
Merge conflict on next branch — needs rebase. The systemd-homed patch itself is well-structured with clear upstream tracking and exit condition. CI validate passes. Please rebase and re-push.
It didn't have a merge conflict earlier, but it looks like 963 was pushed straight to the next branch without my authorship? I'll rebase this anyways. |
Closes projectbluefin#962 Assisted-by: Claude Sonnet 4.6 via GitHub Copilot
|
This PR targets |
dd85e40 to
eb7227c
Compare
Integrates a patch to enable
systemd-homedunconditionally across the GNOME stack. This involves:-Dcreate_homed=trueinaccountsservice.malcontentdependencies and disabling parental controls fromgnome-control-center,gnome-initial-setup, andgnome-software.DefaultStorage=subvolumefor homed home directories.This is a port of
gnome-build-meta!2681.Summary by CodeRabbit
New Features
Chores