Short names for staged policies #10280
Conversation
marvin-tigera
added
release-note-required
MichalFupso
added
docs-not-required
| p.StorageType, | ||
| authorizer, | ||
| []string{}, | ||
| []string{"sgnp", "csgnp", "calicostagedglobalnetworkpolicies"}, |
There was a problem hiding this comment.
We should add calicostagedglobalnetworkpolicy.
|
I think we should add short names for |
MichalFupso
force-pushed
the
stagedpolicy-shortname
branch
from
8135f19 to
e79d543
Compare
| p.StorageType, | ||
| authorizer, | ||
| []string{}, | ||
| []string{"csnp", "calicostagednetworkpolicy", "calicostagednetworkpolicies"}, |
There was a problem hiding this comment.
I think these names are a bit confusing: the resource kind is StagedNetworkPolicy, so these should allude to that. I think it's also preferable to have the s appear at the start. So here I think the good options would be "snp", "stagednetworkpolicy".
There was a problem hiding this comment.
And then maybe add "scnp", "stagedcaliconetworkpolicy"
There was a problem hiding this comment.
I think for this one we might be good with just the "snp", if we would want to add the calico differentiation we should follow the same order as for networkpolicy which has calico at front (caliconetworkpolicy)
There was a problem hiding this comment.
:( - so much inconsistency. Ah well. I think the names I'd like to see most are the ones that are just word->letter mappings from the kind in the same ordering.
There was a problem hiding this comment.
Yeah, agreed - the important one here is snp I think
| p.StorageType, | ||
| authorizer, | ||
| []string{}, | ||
| []string{"sgnp", "csgnp", "calicostagedglobalnetworkpolicies", "calicostagedglobalnetworkpolicy"}, |
There was a problem hiding this comment.
I don't think we should have the csgnp option (keep staged in front), and I don't think we need the Calico qualifier either since there is no k8s GlobalNetworkPolicy
(cherry picked from commit 7764bd5)
MichalFupso
added
cherry-pick-completed
5 participants
Description
Allow the use of short names for Staged Policies
StagedNetworkPolicy -> snp
StagedGlobalNetworkPolicy -> sgnp
StagedKubernetesNetworkPolicy -> sknp
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.