[CORE-10981] Move bandwidth code to pkg/bandwidth #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coutinhop
force-pushed
the
pedro-CORE-10981
branch
5 times, most recently
from
2e4a227 to
f4110bd
Compare
|
|
coutinhop
force-pushed
the
pedro-CORE-10981
branch
2 times, most recently
from
1989329 to
030d859
Compare
This includes a breaking change: vishvananda/netlink@acdc658 route.Dst is now a zero IPNet instead of nil Signed-off-by: Etienne Champetier <[email protected]>
Just attempt to delete the known rules referring to the custom chain, then flush and delete it. If the latter succeeds, no referencing rules are left and the job is done. If the final flush'n'delete fails, fall back to the referencing rule search which is slow with large rulesets. Signed-off-by: Phil Sutter <[email protected]>
Move bandwidth functionality to pkg/bandwidth, make it an importable
module. Import it and use it in plugins/meta/bandwidth/main.go.
Add a qdiscType arg to CreateEgressQdisc() so that both "ingress" and
"clsact" qdiscs may be used ("ingress" is the default used by the
bandwidth plugin).
All of this has the objective of enabling Calico to apply the netlink
qdisc configuration natively by importing this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move bandwidth functionality to pkg/bandwidth, make it an importable
module. Import it and use it in plugins/meta/bandwidth/main.go.
Add a qdiscType arg to CreateEgressQdisc() so that both "ingress" and
"clsact" qdiscs may be used ("ingress" is the default used by the
bandwidth plugin).
All of this has the objective of enabling Calico to apply the netlink
qdisc configuration natively by importing this module.
note, the first 2 commits in this PR are cherry-picks in order to update vishvananda/netlink to v1.3.0 and fix CI, the relevant changes are in the last commit: 030d859