fix hostport CNAT entry handling #851
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sknat
reviewed
Dec 9, 2025
| PblIndexes map[string]uint32 `json:"pblIndexes"` | ||
| // HostPortEntryIDs is a map from hostport to corresponding cnat entry ids | ||
| // in VPP, it may correspond to 2 ids (v4 and v6) | ||
| HostPortEntryIDs map[uint16][]uint32 |
Collaborator
There was a problem hiding this comment.
Could we maybe make this a map[netip.Addr][uint16] instead ?
and key the cnat entries by hostIP and hostPort
| stack.Push(s.vpp.CnatTranslateDel, id) | ||
| } | ||
| podSpec.HostPorts[idx].EntryID = id | ||
| podSpec.HostPortEntryIDs[hostPort.HostPort] = append(podSpec.HostPortEntryIDs[hostPort.HostPort], id) |
Collaborator
There was a problem hiding this comment.
Here we would then log an error if we find a conflicting entry in the map
Collaborator
Author
There was a problem hiding this comment.
Which kind of conflict are you thinking about ?
Hostport-backed pods now create CNAT entries that may be IPv4 or IPv6. Previously, a unique entry ID was stored per hostport; this change moves hostport entry IDs into LocalPodSpecStatus, as they are internal to VPP. This update also resolves cleanup issues during pod deletion, addressing leftover state that occurred with the previous deletion logic.
hedibouattour
force-pushed
the
fix-hostport-entries-deleting
branch
from
a30bf51 to
d746e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hostport-backed pods now create CNAT entries that may be IPv4 or IPv6. Previously, a unique entry ID was stored per hostport; this change moves hostport entry IDs into LocalPodSpecStatus, as they are internal to VPP.
This update also resolves cleanup issues during pod deletion, addressing leftover state that occurred with the previous deletion logic.