This repository was archived by the owner on Apr 24, 2024. It is now read-only.
feat: implement csv export #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winged
suggested changes
Sep 14, 2022
winged
left a comment
winged
left a comment
There was a problem hiding this comment.
Looking good so far! I like that you're going the async way, I think it's a good project to get some python async experience
| async def get_caluma_data(request): | ||
| data = await request.content.read() | ||
| data_object = json.loads(data) | ||
| data_object["query"] = data_object["query"].replace("\n", "") |
There was a problem hiding this comment.
Should not be needed, or why is this here?
| async with ClientSession() as session: | ||
| async with session.post( | ||
| env.str("CALUMA_ENDPOINT", default="http://caluma:8000/graphql"), | ||
| "http://localhost:8000/graphql", |
Comment on lines
+56
to
+57
| part = mpwriter.append(",".join(headers), {"Content-Type": "text/csv"}) | ||
| part.set_content_disposition("attachment", filename="export.csv") |
There was a problem hiding this comment.
I suggest using the CSV module for generating CSV - this way, you're getting proper quoting etc for free
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe multipart isnt the right choice?