Skip to content

Conversation

@czosel
Copy link
Contributor

@czosel czosel commented Oct 13, 2025

Todos:

  • upgrade git workflow to use node v22 (ember-cli node compat list)
  • add "@ember/string" to devDependencies <-- formerly was added to dependencies which was wrong
  • run yarn lint and fix alle the errors
  • run ember test -s with the deprecation-workflow's throwOnUnhandled set to true (/tests/dummy/app/deprecation-workflow.js and fix errors

@derrabauke
Copy link
Contributor

Summary of changes coming via ember-cli-update command run: ember-cli/ember-addon-output@v4.12.3...v6.4.0

@derrabauke
Copy link
Contributor

@MitanOmar I've added a list of ToDos in the description of the MR. Please check all those and tick them off if done.

If all of the above is done it should work. Otherwise ping me again and we do another pair review ;-)

@derrabauke
Copy link
Contributor

Let's try https://github.com/ijlee2/ember-codemod-remove-inject-as-service to remove old service injections.

@MitanOmar
Copy link
Member

Let's try https://github.com/ijlee2/ember-codemod-remove-inject-as-service to remove old service injections.

@derrabauke i run this, but the @ember/string issue still exists

@derrabauke
Copy link
Contributor

Let's try https://github.com/ijlee2/ember-codemod-remove-inject-as-service to remove old service injections.

@derrabauke i run this, but the @ember/string issue still exists

This has nothing to do with each other.

@MitanOmar MitanOmar mentioned this pull request Nov 7, 2025
@derrabauke derrabauke force-pushed the upgrade-everything branch 4 times, most recently from 56cc2e9 to 6806ee9 Compare November 11, 2025 14:48
@derrabauke
Copy link
Contributor

@MitanOmar I've got the test setup working again with the latest commits. Could you please complete the task by adding { owner: this.engine } to the rendering calls like I already started within 6806ee9 ?

Eventually some service lookups also need to get adapted like described in the ember engine docs.

@MitanOmar MitanOmar force-pushed the upgrade-everything branch 5 times, most recently from f2404ec to ea80e71 Compare November 19, 2025 17:58
@derrabauke
Copy link
Contributor

@MitanOmar let's add

      embroiderSafe({ allowedToFail: true }),
      embroiderOptimized({ allowedToFail: true }),

to tests/dummy/config/ember-try.js for now. We can see about embroider compatibility later.

@MitanOmar MitanOmar requested a review from derrabauke November 24, 2025 14:49
@derrabauke derrabauke marked this pull request as ready for review November 24, 2025 15:35
@derrabauke derrabauke merged commit 5515bc7 into main Nov 24, 2025
14 checks passed
@derrabauke derrabauke deleted the upgrade-everything branch November 24, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants