-
Notifications
You must be signed in to change notification settings - Fork 5
chore: upgrade dependencies #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Summary of changes coming via |
|
@MitanOmar I've added a list of ToDos in the description of the MR. Please check all those and tick them off if done. If all of the above is done it should work. Otherwise ping me again and we do another pair review ;-) |
61e62ea to
bdaaf95
Compare
|
Let's try https://github.com/ijlee2/ember-codemod-remove-inject-as-service to remove old |
@derrabauke i run this, but the |
This has nothing to do with each other. |
56cc2e9 to
6806ee9
Compare
|
@MitanOmar I've got the test setup working again with the latest commits. Could you please complete the task by adding Eventually some service lookups also need to get adapted like described in the ember engine docs. |
6806ee9 to
ee9749e
Compare
f2404ec to
ea80e71
Compare
|
@MitanOmar let's add embroiderSafe({ allowedToFail: true }),
embroiderOptimized({ allowedToFail: true }),to |
3a71449 to
cf78d45
Compare
Todos:
devDependencies<-- formerly was added todependencieswhich was wrongyarn lintand fix alle theerrorsember test -swith the deprecation-workflow'sthrowOnUnhandledset totrue(/tests/dummy/app/deprecation-workflow.jsand fix errors