Skip to content

support different-length inputs in xor()#300

Merged
Mzack9999 merged 2 commits intomainfrom
fix/xor-different-length-inputs
Apr 15, 2026
Merged

support different-length inputs in xor()#300
Mzack9999 merged 2 commits intomainfrom
fix/xor-different-length-inputs

Conversation

@dogancanbakir
Copy link
Copy Markdown
Member

@dogancanbakir dogancanbakir commented Apr 6, 2026

Closes #297

  • Cycle shorter inputs using modulo indexing instead of rejecting length mismatches
  • Backward compatible: same-length inputs behave identically

@dogancanbakir dogancanbakir requested a review from Mzack9999 April 15, 2026 06:24
@dogancanbakir dogancanbakir self-assigned this Apr 15, 2026
@dogancanbakir dogancanbakir requested a review from knakul853 April 15, 2026 06:24
@Mzack9999 Mzack9999 merged commit 823aa1c into main Apr 15, 2026
7 checks passed
@Mzack9999 Mzack9999 deleted the fix/xor-different-length-inputs branch April 15, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@knakul853 knakul853 Awaiting requested review from knakul853

Assignees

@dogancanbakir dogancanbakir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

xor() function should support different-length inputs

2 participants

@dogancanbakir @Mzack9999