refactor: switch from Knetic/govaluate to projectdiscovery fork#305
Open
ChrisJr404 wants to merge 1 commit intoprojectdiscovery:mainfrom
Open
refactor: switch from Knetic/govaluate to projectdiscovery fork#305ChrisJr404 wants to merge 1 commit intoprojectdiscovery:mainfrom
ChrisJr404 wants to merge 1 commit intoprojectdiscovery:mainfrom
Conversation
github.com/Knetic/govaluate has been archived. Switch all import paths in the source tree and go.mod to the maintained fork at github.com/projectdiscovery/govaluate (bug fixes + perf improvements, API-compatible). All tests still pass.
Neo - PR Security ReviewNo security issues found Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/Knetic/govaluateis archived. The maintained fork atgithub.com/projectdiscovery/govaluateis API-compatible and ships the bug fixes + perf improvements that have accumulated over the years (most recently nuclei#5580 quote-string parsing).This swap unblocks the same migration on the nuclei side (see projectdiscovery/nuclei#7380) — without it, dsl's exported helper types collide with nuclei's import-path swap because go modules can't satisfy two different module paths from the same source.
Changes
engine.go,dsl.go,func.go,dsl_test.go,dsl_benchmark_test.go— replacegithub.com/Knetic/govaluatewithgithub.com/projectdiscovery/govaluatein imports.go.mod/go.sum— drop the Knetic require, add the projectdiscovery fork.No public-API changes. The
govaluate.ExpressionFunction/govaluate.NewEvaluableExpression*types and constructors that callers reach for stay shape-identical.Tests
go test ./...— all packages still pass.