-
Notifications
You must be signed in to change notification settings - Fork 911
Added struct tags to Runner Options #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes add JSON and YAML struct tags to all fields within the Changes
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
runner/options.go
(2 hunks)
🔇 Additional comments (3)
runner/options.go (3)
54-110
: Struct tag addition for ScanOptions is well-structured
The JSON and YAML tags onScanOptions
fields follow a consistent snake_case naming convention and correctly useomitempty
to omit zero values during serialization. This will improve interoperability without altering behavior.
174-193
: Struct tag addition for initial Options fields looks good
The tags on the first block ofOptions
fields (fromCustomHeaders
throughRequestURI
) consistently use snake_case withomitempty
. This aligns with the rest of the codebase and will facilitate seamless JSON/YAML marshaling.
195-313
: Remaining Options struct tags are consistent
The rest of theOptions
struct fields (excluding function‐typed fields) use snake_case andomitempty
consistently across JSON and YAML tags. These additions enhance serialization capabilities without side effects.Also applies to: 345-351
Will double-check coder rabbit's responses at some point today.... |
Thanks for your contribution @l0nedigit ! :) |
To help converting between PD defined structs and personal project structures via pkg use, I added some struct tags to the runner Options struct for json & yaml.
Summary by CodeRabbit