Skip to content

fix(-pr http11): disable retryablehttp HTTP/2 fallback when http11 protocol is forced #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
usernametooshort wants to merge 1 commit into from
+5 −1
Closed

fix(-pr http11): disable retryablehttp HTTP/2 fallback when http11 protocol is forced #2438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/httpx/httpx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,13 @@ func New(options *Options) (*HTTPX, error) {
}

if httpx.Options.Protocol == "http11" {
// disable http2
// disable http2 at transport level
_ = os.Setenv("GODEBUG", "http2client=0")
transport.TLSNextProto = map[string]func(string, *tls.Conn) http.RoundTripper{}
// also disable the HTTP/2 fallback in retryablehttp-go so that
// malformed-HTTP/2 errors do not cause a silent protocol upgrade
// via HTTPClient2 (see projectdiscovery/retryablehttp-go#532)
retryablehttpOptions.DisableHTTP2Fallback = true
}

if httpx.Options.SniName != "" {
Expand Down