-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to use latest fingerprints_data.json file #122
base: main
Are you sure you want to change the base?
Conversation
@scottdharvey I'm not crazy familiar with this codebase (just began using it) but I was curious if there was method(s) / thoughts on merging the embedded signature with a custom provided one rather than an overwrite operation. The use case I was considering was if there was already an app / signature defined (in this case I was trying to figure out why this wasn't detecting the use of Webflow on one of my domains) and thought if you brought your own signature or detection methods that it could be appended to the existing app instead of totally overwriting it. I realize that you could simply take the defined signature in the embedded file and then add whatever you wanted to it so that when it was overwritten it would include your "total" but figured I'd ask! Appreciate the work you / projectdiscovery team are doing with these libraries, so useful <3 |
@matoszz I am not opposed to the change, but it might make things cluttered unless I introduce I'd be willing to add it if others think it would be the right direction. |
@scottdharvey I'm personally a huge fan of functional options parameters, but I'm also not yet a contributor or maintainer of this project so don't want to speak out of turn. While it's not directly relevant to this specific repo (since there weren't actually a ton of options to include) I did recently open a PR on one of my projects which creates wrappers around several of the other projectdiscovery tools ( If you wanted to limit the scope of your current pull request to what you've already written to get it merged, I'd be willing to take a stab at expanding on the functionality with what I proposed above ^ as well |
This is only my 2nd contribution to PD, and my first to this repo, so I don't have any authority either. Personally, I would prefer not to introduce this new I can move |
I wanted the option to use the latest
fingerprints_data.json
in my applications without having to rebuild the binary with the latest embedded file. Taking #109 into account, I added an option to include the already-embedded file, as well as an option to overwrite the embedded signatures when the app name conflicted.This is similar to #109 and takes its intentions into account. Where #109 would break existing uses of
New()
, this will not. It adds a new exported function for this specific use case, and one non-exported function for loading the file.This allows a user to combine the embedded file with their own custom signatures, or use only their custom signatures. If the user's signatures include one or more app name that is included in the embedded signatures, they can optionally overwrite the embedded version with their custom version with the
supersede
flag. (this could be changed tooverwrite
as well)