feat!: new RESTClient - #52
Open
HeadTriXz wants to merge 6 commits into
Open
Conversation
TTtie
added
type: enhancement
TTtie
reviewed
Mar 18, 2023
TTtie
left a comment
TTtie
left a comment
Member
There was a problem hiding this comment.
Here's a summary of my initial thoughts on this PR:
By the way, please rebase :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request deprecates all REST methods of
Clientand moves them into a new class calledRESTClient. This will allow for making requests without needing to create an instance ofClient.In addition, this PR introduces a completely new
RequestHandler, which will handle requests made throughRESTClient. The newRequestHandlerprovides better performance and less spaghetti code 🍝.The implementation of
RESTClienthas been designed with full backwards compatibility in mind, so existing code should continue to work seamlessly. One significant improvement in this PR is the use ofundici's fetch function for making HTTP requests.As this is a significant change, extensive testing will be required to ensure its stability and correctness.
It also heavily depends on #46. Therefore, this PR will remain a draft until all testing is completed and #46 is merged.Please review the changes and provide feedback as needed.
The new files currently use a different coding style (see class fields) than the rest of the library. It may, or may not change in the future, depending on #46.