Fix type safety for FluentVariable #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry for not getting to this earlier. It looks like there's at least one type assertion that we can remove if making TemporalObject more specific? |
Contributor
Author
|
You are right. I have fixed that now |
eemeli
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, you can assign anything to FluentVariable. This is because TemporalObject only requires
toString()and everything in JS has it in the prototype.PR makes TemporalObject stricter by requiring either
epochMilliseconds(Instant),calendarId(all the date types) orhour,minute,second(PlainTime).This is not perfect, but at least it restores some type safety for FluentVariable.