Make the config filter a little more robust about what it accepts#242
Make the config filter a little more robust about what it accepts#242doctormo wants to merge 1 commit into
Conversation
|
Thanks for the PR. Most of my time is spend on the If you would be so kind as to create an issue with more information about what problem this PR addresses, that would be most helpful! |
|
Your project doesn't have the issue tracker switched on here. Although there isn't much more to say, it fixes a very specific error caused probably only in the very specific instance. It should be possible to shallow review this. |
|
Thanks for your feedback.
True, and thanks to your comment I just realized that outside it is only
The reason i suggested creating an issue was that it allows search engines to pick up on the particular error message thrown if anyone else encounters it as well as helps separating the documentation of the problem from the solution. A distinction that sometimes seems a bit tedious with more trivial issues.
The underlying issue is, at least in part, that clearly there is a significant mismatch betwen the docstring and the actual code. according to the docstring, we should not even accept string instances. While far from rocket sience, there seems to be more about this than just simply merging the PR as is. Once again, I want to avoid to put you off with those remarks but rather shed some light on the general process. either way, we are very happy for your contribution! |
|
|
Without this, hamster-gtk caused an error on Ubuntu 16.04 via virtualenv -> python2.7 + vext.gi