This repository was archived by the owner on Mar 13, 2021. It is now read-only.
Add analyzed arg to analyze and export steps#66
Merged
trisberg merged 2 commits intoprojectriff:masterfrom Jul 17, 2019
Merged
Conversation
Member
scothis
reviewed
Jul 10, 2019
Member
scothis
left a comment
scothis
left a comment
There was a problem hiding this comment.
Looks good, but can you also add it to the function builder before merging
Member
|
Looks like this flag is part of lifecycle 0.3, which is not fully released. We'll need to pickup a pack 0.3 before merging |
Member
Author
|
It's already included in the default builder |
This should help avoid accidental breakage in the future
scothis
approved these changes
Jul 17, 2019
Member
scothis
left a comment
scothis
left a comment
There was a problem hiding this comment.
Pinning the builder should alleviate concerns about accidental breakages in the future. We should apply the change to the function builder only once pack 0.3 is available.
nebhale
added
semver:minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65