(bug) ResourceSummary collection #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When agents are deployed in managed cluster, collecting ResourceSummary from the management cluster always caused an error to be logged (configMap projectsveltos/drift-detection-version missing). That is because ResourceSummary CRD is present in the management cluster irrespective of whether there is a profile in drift detection mode is matching the management cluster. To fix this, irrespective of the mode, always collect clusters with drift detection deployed and only collect resourceSummary instances from those clusters. This PR also fixes a crash when Sveltos is referencing a Flux Source and the Flux source is deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When agents are deployed in managed cluster, collecting ResourceSummary from the management cluster always caused an error to be logged (configMap projectsveltos/drift-detection-version missing).
That is because ResourceSummary CRD is present in the management cluster irrespective of whether there is a profile in drift detection mode is matching the management cluster.
To fix this, irrespective of the mode, always collect clusters with drift detection deployed and only collect resourceSummary instances from those clusters.
This PR also fixes a crash when Sveltos is referencing a Flux Source and the Flux source is deleted.
Fixes #1158
Fixes #1159