Conversation
TheBigLee
force-pushed
the
refactor
branch
9 times, most recently
from
742cc2a to
31fed67
Compare
TheBigLee
added
enhancement
TheBigLee
force-pushed
the
refactor
branch
2 times, most recently
from
10df627 to
002af82
Compare
simu
left a comment
simu
left a comment
There was a problem hiding this comment.
Can't really properly review this since there's almost no context for the changes (i.e. it's hard to tell if the changes are correct/make sense without any information about the why).
I assume https://github.com/projectsyn/component-vcluster/blob/master/docs/modules/ROOT/pages/how-tos/oidc.adoc and https://github.com/projectsyn/component-vcluster/blob/master/docs/modules/ROOT/pages/tutorials/installation-openshift.adoc are outdated as well, given all the changes in this PR.
| role: | ||
| extraRules: | ||
| - apiGroups: [""] | ||
| resources: ["endpoints/restricted"] |
There was a problem hiding this comment.
Interesting context openshift/kubernetes#899 (comment)
TheBigLee
force-pushed
the
refactor
branch
9 times, most recently
from
59af946 to
6daeeab
Compare
TheBigLee
force-pushed
the
refactor
branch
8 times, most recently
from
a838124 to
8e60b1c
Compare
|
I've done some refactorings and changes. Please review again |
Only the installation-openshift.adoc was outdated. |
simu
left a comment
simu
left a comment
There was a problem hiding this comment.
From a fairly quick review, there's no glaring issues anymore.
See inline for some things that might need another look .
This will refactor the component completely to use the latest official helm chart. Due to this change, there are a few breaking changes that will have to be handled carefully. Check the docs for more information Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
simu
left a comment
simu
left a comment
There was a problem hiding this comment.
Should be safe enough to merge now, since afaik you're already using this version for one of your vclusters.
3 participants
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.