Fix mtypes zero divide when the input has no summary metrics or no histogram metrics #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringerc
force-pushed
the
fix-mtypes-zero-divide
branch
from
45993fa to
64edc31
Compare
This makes them easier to test. The function to compute avalanche flags now generates a []string of flags instead of writing directly to an output stream. Signed-off-by: Craig Ringer <[email protected]>
Signed-off-by: Craig Ringer <[email protected]>
Signed-off-by: Craig Ringer <[email protected]>
This can be seen when the input doesn't have any summary metrics, as in
this minimal example:
$ ./mtypes < /dev/null -avalanche-flags-for-adjusted-series 10
./mtypes < /dev/null -avalanche-flags-for-adjusted-series 10
Metric Type Metric Families Series (adjusted) Series (adjusted) % Average Buckets/Objectives
--- --- --- --- ---
* 0 0 (0) 100.000000 (100.000000) -
Avalanche flags for the similar distribution to get to the adjusted series goal of: 10
panic: runtime error: integer divide by zero
goroutine 1 [running]:
main.computeAvalancheFlags(0x8a55a0?, {0x0, 0x0, 0x0, 0x0, 0x0}, 0xc0001239b0)
[...]/avalanche/cmd/mtypes/main.go:127 +0xcbd
main.main()
[...]/avalanche/cmd/mtypes/main.go:81 +0x5c5
Add a test to repro it.
Signed-off-by: Craig Ringer <[email protected]>
Signed-off-by: Craig Ringer <[email protected]>
The cmd/mtypes and cmd/avalanche directories were being inadvertently gitignore'd because the .gitignore didn't specify that only these names at the root of the project should be ignored. Signed-off-by: Craig Ringer <[email protected]>
ringerc
force-pushed
the
fix-mtypes-zero-divide
branch
from
64edc31 to
588b9fa
Compare
|
Anyone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a zero-divide crash in
mtypesif the input lacks either summary metrics or histogram metrics.In the process, add test cover for the
-avalanche-flags-for-adjusted-seriesflag, and expand the other mtypes tests a bit.Fixes #136