Refactor slm collector #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sysadmind
commented
Sep 13, 2024
sysadmind
commented
- Move metric Desc to vars to aid in unused linter checks
- Use new Collector interface
- Move metric Desc to vars to aid in unused linter checks - Use new Collector interface Signed-off-by: Joe Adams <[email protected]>
SuperQ
approved these changes
Sep 14, 2024
Signed-off-by: Joe Adams <[email protected]>
rtkkroland
pushed a commit
to rtkwlf/elasticsearch_exporter
that referenced
this pull request
Jan 28, 2025
- Move metric Desc to vars to aid in unused linter checks - Use new Collector interface Signed-off-by: Joe Adams <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Feb 26, 2025
BREAKING CHANGES: The flag `--es.slm` has been renamed to `--collector.slm`. The logging system has been replaced with log/slog from the stdlib. This change is being made across the prometheus ecosystem. The logging output has changed, but the messages and levels remain the same. The `ts` label for the timestamp has bewen replaced with `time`, the accuracy is less, and the timezone is not forced to UTC. The `caller` field has been replaced by the `source` field, which now includes the full path to the source file. The `level` field now exposes the log level in capital letters. * [CHANGE] Rename --es.slm to --collector.slm #932 * [CHANGE] Replace logging system #942 * [ENHANCEMENT] Add external refresh stats #933 Signed-off-by: SuperQ <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.