Skip to content

streamlined System/CentralManagement/Status probe name - #365

Open
rnxmlu wants to merge 13 commits into
prometheus-community:mainfrom
rnxmlu:pr-central-management
Open

streamlined System/CentralManagement/Status probe name#365
rnxmlu wants to merge 13 commits into
prometheus-community:mainfrom
rnxmlu:pr-central-management

Conversation

@rnxmlu

@rnxmlu rnxmlu commented Feb 6, 2026

Copy link
Copy Markdown
Contributor
  • skipped the dash ("-") and used camelCase as for all the other probes

Signed-off-by: Michael Lucka michael.lucka@rnetx.com

Philldomd and others added 13 commits February 6, 2026 14:06
* Central management status added

---------

Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
Signed-off-by: Philip Örnfeldt <1583206+Philldomd@users.noreply.github.com>
Signed-off-by: Philip Örnfeldt <philip.ornfeldt@outlook.com>
Co-authored-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
Move the metrics documentation to a separate file to reduce the size of
the main README.

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
…mmunity#352)

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 6.0.0 to 6.1.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@4469467...4dc6199)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-version: 6.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Schubert <16682281+bastischubert@users.noreply.github.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
…ommunity#353)

Bumps [prometheus/promci](https://github.com/prometheus/promci) from 0.4.7 to 0.5.3.
- [Release notes](https://github.com/prometheus/promci/releases)
- [Commits](prometheus/promci@443c7fc...c0916f0)

---
updated-dependencies:
- dependency-name: prometheus/promci
  dependency-version: 0.5.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Schubert <16682281+bastischubert@users.noreply.github.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
…mmunity#356)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 6.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.2.2...8e8c483)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
…rometheus-community#357)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 8.0.0 to 9.2.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@4afd733...1e7e51e)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-version: 9.2.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Schubert <16682281+bastischubert@users.noreply.github.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
Add a new probe that retrieves device latitude and longitude from
/api/v2/cmdb/system/global and exposes them as an info metric:

  fortigate_location_info{latitude, longitude} 1

The probe is best-effort and returns success even when the location
metadata is not configured.

Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
- skipped the dash ("-") and used camelCase as for all the other probes

Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
@rnxmlu
rnxmlu force-pushed the pr-central-management branch from 431e36c to 63805ba Compare February 6, 2026 13:06
@bastischubert

Copy link
Copy Markdown
Contributor

@rnxmlu can you help me understanding this PR, or should it just be closed?

@rnxmlu

rnxmlu commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

@rnxmlu can you help me understanding this PR, or should it just be closed?

I'm not quite sure about all the changes included in this PR, maybe i made a mistake during the Github PR workflow. It's the first time that i'm trying to collaborate a little bit more to existing projects using the "official" way... 😬

the relevant changes are in the following commit: 63805ba

If it is to complicated to merge / cherry-pic you can close this PR and i'll create a new one. My idea was to streamline the name of this probe according to all the other names...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants