fix: correct version comparison for FortiOS 7.4+ feature gates - #383
Merged
bastischubert merged 1 commit intoMar 26, 2026
Merged
Conversation
The check 'VersionMajor >= 7 && VersionMinor >= 4' fails for future major versions with minor < 4 (e.g., 8.0 would not match). Use 'VersionMajor > 7 || (VersionMajor == 7 && VersionMinor >= 4)' to correctly express 'version 7.4 or later'. Signed-off-by: Aprazors <Aprazors@gmail.com>
Aprazor
force-pushed
the
fix/version-guard-logic-error
branch
from
March 21, 2026 04:54
7923649 to
462bf39
Compare
bastischubert
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check 'VersionMajor >= 7 && VersionMinor >= 4' fails for future
major versions with minor < 4 (e.g., 8.0 would not match). Use
'VersionMajor > 7 || (VersionMajor == 7 && VersionMinor >= 4)' to
correctly express 'version 7.4 or later'.