fix(probe): use switch-id field for managed switch name on FortiOS 7.4+ - #400
Merged
Conversation
FortiOS 7.4 replaced the 'name' field with 'switch-id' in the managed-switch/status API response. Without this fix, all switches had an empty switch_name label causing duplicate metric errors. Fixes: #392 Signed-off-by: Sebastian Schubert <basti@schubert.digital>
Contributor
Author
|
@Philldomd fyi |
Contributor
|
We should look into how to test that with go test somehow. A step called prom validation that does more than check strings against each other. Add a test file for this so the ci passes for now. |
Signed-off-by: Sebastian Schubert <basti@schubert.digital>
Contributor
Author
|
@Philldomd sorry i seem to have missed the testdata in the commit earlier today. |
Philldomd
approved these changes
Apr 20, 2026
|
looks good guys <3 |
SuperQ
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FortiOS 7.4 replaced the 'name' field with 'switch-id' in the
managed-switch/status API response. Without this fix, all switches
had an empty switch_name label causing duplicate metric errors.
Fixes: #392