[kube-prometheus-stack] allow extraManifests as map/list

[TheRealNoob]

What this PR does / why we need it

Allow extraManifests to be of type map or list. Useful for splitting the values across multiple files, such as one encrypted and another not.

Which issue this PR fixes

None

Special notes for your reviewer

Checklist

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

[jkroepke]

Could you please add a extraManifests example here (list) that contains object and string elements?

https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/ci/03-non-defaults-values.yaml

and here a example with strings and objects, but extraManifests is an object:

https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/ci/05-ingress-and-gateway-routes-values.yaml

That should cover all possibilities through CI.

[TheRealNoob]

Will do. In the sake of testing I will share the helm-unittests that I wrote for one of our internal charts. All of these tests pass. Hopefully that gives you some confidence. The only difference is this chart doesn't call it extraManifests but manifests.

https://gist.github.com/TheRealNoob/ca7dee0e862a4e5526a115d54e863ec9

[GMartinez-Sisti]

Will do. In the sake of testing I will share the helm-unittests that I wrote for one of our internal charts. All of these tests pass. Hopefully that gives you some confidence. The only difference is this chart doesn't call it extraManifests but manifests.

https://gist.github.com/TheRealNoob/ca7dee0e862a4e5526a115d54e863ec9

We have some tests on https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack/unittests, if you have them already you can add them.

[jkroepke]

LGTM. But Gitleaks has some issues.

Optionally, add the unit tests, if you wish. @GMartinez-Sisti not sure, if they part of CI

[GMartinez-Sisti]

LGTM. But Gitleaks has some issues.

Optionally, add the unit tests, if you wish. @GMartinez-Sisti not sure, if they part of CI

They are disabled 😢 : https://github.com/prometheus-community/helm-charts/blob/main/.github/linters/ct.yaml#L4

Will send a PR to enable as I think there is great value on this.

[TheRealNoob]

I removed the linting tests and added the unittest since it's more comprehensive. This should also fix the gitleaks error.

@GMartinez-Sisti unfortunately not all of the tests pass right now, but I at least made sure that extraObjects does. Here is the output so you can have a look. Also I changed the command slightly because it ran my test twice - find it at the top of the gist. The reason I placed the test at unittests/extra-objects_test.yaml is because I figure we're supposed to follow the format of the templates/ dir, which I did. It just happens to be the singular exception to the structure.

[TheRealNoob]

@jkroepke ready for merge?

[jkroepke]

LGTM - Thanks