[prometheus-pushgateway] add support for basicAuth in ServiceMonitor #5489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiaxinonly <[email protected]>
Signed-off-by: jiaxinonly <[email protected]>
|
I have re-created the PR and completed the DCO. Please review it. Thank you. @cstaud @gianrubio @zeritti |
zeritti
requested changes
Mar 30, 2025
There was a problem hiding this comment.
Thank you, @jiaxinonly, for your PR. Please, see my comments below.
Co-authored-by: zeritti <[email protected]> Signed-off-by: 悲鸣 <[email protected]>
Signed-off-by: jiaxinonly <[email protected]>
|
Thank you for your suggestion. @zeritti I have made the revision. |
Signed-off-by: zeritti <[email protected]>
Signed-off-by: zeritti <[email protected]>
Signed-off-by: zeritti <[email protected]>
Signed-off-by: zeritti <[email protected]>
Signed-off-by: zeritti <[email protected]>
Signed-off-by: zeritti <[email protected]>
Signed-off-by: zeritti <[email protected]>
Thank you, @jiaxinonly. I allowed myself to add CI test cases, minor corrections and to amend some of your changes. |
Signed-off-by: zeritti <[email protected]>
zeritti
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add support for basicAuth in ServiceMonitor.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])