[prometheus] add support for runtimeClassName field in pod.spec #5498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neo-liang-sap
requested review from
Xtigyro,
gianrubio,
naseemkullah,
zanhsieh and
zeritti
as code owners
neo-liang-sap
force-pushed
the
add-runtimeClassName
branch
from
8222ef1 to
6fa741d
Compare
Signed-off-by: Neo Liang <[email protected]> Signed-off-by: Neo Liang <[email protected]> Signed-off-by: Neo Liang <[email protected]>
neo-liang-sap
force-pushed
the
add-runtimeClassName
branch
from
b604567 to
2bfbf4f
Compare
zeritti
requested changes
Apr 2, 2025
Contributor
zeritti
left a comment
zeritti
left a comment
There was a problem hiding this comment.
Thank you, @neo-liang-sap, for your PR. Please, add the field in template sts.yaml as well. The chart version needs a bump (a minor change in this case).
Contributor
Author
thanks @zeritti , i've changed the sts.yaml and also bumped version |
zeritti
requested changes
Apr 3, 2025
Contributor
zeritti
left a comment
zeritti
left a comment
There was a problem hiding this comment.
Thanks, @neo-liang-sap. Please, check the chart version.
Co-authored-by: zeritti <[email protected]> Signed-off-by: Neo Liang <[email protected]>
Contributor
Author
|
thanks @zeritti , sorry my typo, i've committed the changes |
zeritti
approved these changes
Apr 3, 2025
Contributor
zeritti
left a comment
zeritti
left a comment
There was a problem hiding this comment.
Thanks, @neo-liang-sap, LGTM
hedgieinsocks
pushed a commit
to hedgieinsocks/prom-helm-charts
that referenced
this pull request
Apr 27, 2025
…etheus-community#5498) Signed-off-by: Neo Liang <[email protected]> Co-authored-by: zeritti <[email protected]> Signed-off-by: Artyom Babiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
this PR add
pod.spec.runtimeClassNamefield support for prometheus chartWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])