[kube-prometheus-stack] Add support for deploying Alertmanager in a custom namespace #5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohamed Shafiq <[email protected]>
Signed-off-by: Mohamed Shafiq <[email protected]>
shafi-elastisys
requested review from
GMartinez-Sisti,
QuentinBisson,
Xtigyro,
andrewgkew,
gianrubio,
gkarthiks,
jkroepke and
scottrigby
as code owners
jkroepke
requested changes
Apr 9, 2025
Signed-off-by: Mohamed Shafiq <[email protected]>
|
Fixed with the latest commit. |
|
Please check the CI failures |
Signed-off-by: Mohamed Shafiq <[email protected]>
Signed-off-by: Mohamed Shafiq <[email protected]>
Signed-off-by: Mohamed Shafiq <[email protected]>
jkroepke
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR introduces support for deploying Alertmanager in a custom namespace by allowing the user to set alertmanager.namespaceOverride. This improves flexibility, especially for multi-namespace or more security-conscious setups, where isolating Alertmanager from other monitoring components is preferred.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])