Skip to content

[prometheus-operator-crds] add opt-out for CRDs #5533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sberz
Copy link
Contributor

@sberz sberz commented Apr 11, 2025

What this PR does / why we need it

This change adds an opt-out mechanism for CRDs so only the CRDs needed for the cluster are installed (e.g. only pod- and servicemonitors for setups using Mimir).

Which issue this PR fixes

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

This change adds an opt-out mechanism for CRDs so only the CRDs needed
for the cluster are installed (e.g. only pod- and servicemonitors for
setups using Mimir).

Resolves: prometheus-community#3860
Signed-off-by: Simon Berz <[email protected]>
@sberz sberz requested a review from QuentinBisson April 11, 2025 09:14
@sberz
Copy link
Contributor Author

sberz commented Apr 11, 2025

The shell format linter seems to complain about a bunch of unchanged lines 😕
I just ran the (hopefully correct) formatter over the entire file now: 6a5a729

Copy link
Member

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you :)

@QuentinBisson QuentinBisson merged commit ed7cf08 into prometheus-community:main Apr 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-operator-crd] Enable or disable some CRDs
2 participants