Skip to content

Conversation

@joawin
Copy link
Contributor

@joawin joawin commented Oct 21, 2025

What this PR does / why we need it

  • Allows use of PodMonitor instead of the traditional ServiceMonitor.

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: Joachim Winkler <[email protected]>
zanhsieh
zanhsieh previously approved these changes Oct 21, 2025
Copy link
Contributor

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joawin, for your PR. I am of the opinion that we should not include custom resources from outside of monitoring.coreos.com in the chart as is the case of PodMonitoring. Please, consider using the field extraManifests for any additional resources you'd like to deploy.

Signed-off-by: Joachim Winkler <[email protected]>
Copy link
Contributor

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joawin By using the values' field extraManifests I meant using this field for your custom resources in your own values at a release install/upgrade. In other words, there is no need to introduce PodMonitoring in the chart in any form.

@joawin
Copy link
Contributor Author

joawin commented Oct 22, 2025

@zeritti why not. We want to deploy it on GCP environment where we need it as Servicemonitor is not supported.
For Blackbox-Exporter it is also implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants