Skip to content

[kube-prometheus-stack] Do not send the bearer token to every service #6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
killerwhile wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[kube-prometheus-stack] Do not send the bearer token to every service #6427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b6f223
[serviceMonitors] Configuration option to not send the bearer token t…
killerwhile Dec 19, 2025
79bc253
Address comments
killerwhile Dec 19, 2025
a05f904
Address comments
killerwhile Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/kube-prometheus-stack/templates/exporters/core-dns/servicemonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ spec:
{{- if .Values.coreDns.serviceMonitor.proxyUrl }}
proxyUrl: {{ .Values.coreDns.serviceMonitor.proxyUrl}}
{{- end }}
{{- if .Values.coreDns.serviceMonitor.sendBearerToken }}
bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
{{- end }}
{{- if .Values.coreDns.serviceMonitor.metricRelabelings }}
metricRelabelings:
{{ tpl (toYaml .Values.coreDns.serviceMonitor.metricRelabelings | indent 4) . }}
Expand Down
4 changes: 4 additions & 0 deletions charts/kube-prometheus-stack/templates/exporters/kube-dns/servicemonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ spec:
{{- if .Values.kubeDns.serviceMonitor.interval }}
interval: {{ .Values.kubeDns.serviceMonitor.interval }}
{{- end }}
{{- if .Values.kubeDns.serviceMonitor.sendBearerToken }}
bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
{{- end }}
{{- if .Values.kubeDns.serviceMonitor.proxyUrl }}
proxyUrl: {{ .Values.kubeDns.serviceMonitor.proxyUrl}}
{{- end }}
Expand All @@ -53,7 +55,9 @@ spec:
{{- if .Values.kubeDns.serviceMonitor.interval }}
interval: {{ .Values.kubeDns.serviceMonitor.interval }}
{{- end }}
{{- if .Values.kubeDns.serviceMonitor.sendBearerToken }}
bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
{{- end }}
{{- if .Values.kubeDns.serviceMonitor.metricRelabelings }}
metricRelabelings:
{{ tpl (toYaml .Values.kubeDns.serviceMonitor.metricRelabelings | indent 4) . }}
Expand Down
2 changes: 2 additions & 0 deletions charts/kube-prometheus-stack/templates/exporters/kube-etcd/servicemonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ spec:
{{- if .Values.kubeEtcd.serviceMonitor.interval }}
interval: {{ .Values.kubeEtcd.serviceMonitor.interval }}
{{- end }}
{{- if .Values.kubeEtcd.serviceMonitor.sendBearerToken }}
bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
{{- end }}
{{- if .Values.kubeEtcd.serviceMonitor.proxyUrl }}
proxyUrl: {{ .Values.kubeEtcd.serviceMonitor.proxyUrl}}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions charts/kube-prometheus-stack/templates/exporters/kube-proxy/servicemonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ spec:
{{- if .Values.kubeProxy.serviceMonitor.interval }}
interval: {{ .Values.kubeProxy.serviceMonitor.interval }}
{{- end }}
{{- if .Values.kubeProxy.serviceMonitor.sendBearerToke) }}
bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
{{- end }}
{{- if .Values.kubeProxy.serviceMonitor.proxyUrl }}
proxyUrl: {{ .Values.kubeProxy.serviceMonitor.proxyUrl}}
{{- end }}
Expand Down
16 changes: 16 additions & 0 deletions charts/kube-prometheus-stack/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2038,6 +2038,10 @@ coreDns:
## https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#servicemonitor
targetLabels: []

## Should bearerToken not be included in the endpoint call.
##
sendBearerToken: true

## Component scraping kubeDns. Use either this or coreDns
##
kubeDns:
Expand Down Expand Up @@ -2136,6 +2140,10 @@ kubeDns:
## https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#servicemonitor
targetLabels: []

## Should bearerToken not be included in the endpoint call.
##
sendBearerToken: true

## Component scraping etcd
##
kubeEtcd:
Expand Down Expand Up @@ -2245,6 +2253,10 @@ kubeEtcd:
## https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#servicemonitor
targetLabels: []

## Should bearerToken not be included in the endpoint call.
##
sendBearerToken: true

## Component scraping kube scheduler
##
kubeScheduler:
Expand Down Expand Up @@ -2451,6 +2463,10 @@ kubeProxy:
## https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#servicemonitor
targetLabels: []

## Should bearerToken not be included in the endpoint call.
##
sendBearerToken: true

## Component scraping kube state metrics
##
kubeStateMetrics:
Expand Down