[kube-prometheus-stack] Add terminationGracePeriodSeconds for Prometheus, Alertmanager and ThanosRuler#6735
Open
DrFaust92 wants to merge 1 commit intoprometheus-community:mainfrom
Conversation
…eus, Alertmanager and ThanosRuler (82.10.4) Exposes the terminationGracePeriodSeconds field for Prometheus, Alertmanager, and ThanosRuler CRs, introduced in prometheus-operator v0.82.0. Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DrFaust92
requested review from
GMartinez-Sisti,
QuentinBisson,
Xtigyro,
andrewgkew,
gianrubio,
gkarthiks and
jkroepke
as code owners
DrFaust92
changed the title
Member
|
@DrFaust92 can you bump the chart version ? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Exposes the
terminationGracePeriodSecondsfield for Prometheus, Alertmanager, and ThanosRuler CRs, introduced in prometheus-operator v0.82.0.Added to:
alertmanager.alertmanagerSpec.terminationGracePeriodSecondsprometheus.prometheusSpec.terminationGracePeriodSecondsthanosRuler.thanosRulerSpec.terminationGracePeriodSecondsAll default to
~(nil/unset) to preserve existing behavior.Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])