[kube-state-metrics] Fix missing rolebindings RBAC rule (7.2.1)#6736
Closed
DrFaust92 wants to merge 1 commit intoprometheus-community:mainfrom
Closed
[kube-state-metrics] Fix missing rolebindings RBAC rule (7.2.1)#6736DrFaust92 wants to merge 1 commit intoprometheus-community:mainfrom
DrFaust92 wants to merge 1 commit intoprometheus-community:mainfrom
Conversation
Add missing list/watch RBAC rule for rolebindings resource so that enabling the rolebindings collector produces kube_rolebinding_info metrics. Also add rolebindings to the commented optional collectors in values.yaml. Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes a missing
list/watchRBAC rule for therolebindingsresource inrole.yaml. Without this rule, enabling therolebindingscollector produces nokube_rolebinding_infometrics even thoughroles,clusterroles, andclusterrolebindingsall work correctly.Also adds
rolebindingsto the commented optional collectors invalues.yamlfor discoverability.Which issue this PR fixes
Special notes for your reviewer
Simple omission — the
rolesblock existed but the correspondingrolebindingsblock was never added.Checklist
[prometheus-couchdb-exporter])