Always write value for apt_upgrades_pending and apt_upgrades_held #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkossen
force-pushed
the
master
branch
2 times, most recently
from
c68a096 to
03591a4
Compare
|
@mpkossen Thanks for this PR, I stumbled across this because my @prometheus-community: Please merge this soon, it's a regression from a monitoring standpoint. Thanks ! |
|
@mpkossen Can you please fix the GH actions Lint/flake8 error ? Unfortunatly the log is expired, so pushing again might trigger a new one. |
…ensure monitoring works. Signed-off-by: Maarten Kossen (mpkossen) <[email protected]>
Signed-off-by: Maarten Kossen (mpkossen) <[email protected]>
Signed-off-by: Maarten Kossen (mpkossen) <[email protected]>
Signed-off-by: Maarten Kossen (mpkossen) <[email protected]>
Signed-off-by: Maarten Kossen (mpkossen) <[email protected]>
|
@dswarbrick Awesome, thanks for the quick response ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always write value for apt_upgrades_pending and apt_upgrades_held to ensure monitoring works.
If there are no held packages or no pending upgrades, nothing is written to apt.prom, resulting in monitoring dashboards not picking up on these values. This patch fixes that by ensuring there's always a value for apt_upgrades_pending and apt_upgrades_held .