Skip to content

Add tcp_conn.sh script #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tcp_conn.sh script #38

wants to merge 1 commit into from

Conversation

badrabubker
Copy link
Contributor

tcp_conn.sh: exposes the number of established TCP connections

@bdrung
Copy link
Contributor

bdrung commented Feb 10, 2020

Please strip the file extension.

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this against master, we now have some shell linting available.

tcp_conn: exposes the number of established TCP connections

Signed-off-by: Badreddin <[email protected]>
Comment on lines +15 to +16
# Author: Badreddin Aboubakr <[email protected]>
# Daniel Swarbrick <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated domain name

Suggested change
# Author: Badreddin Aboubakr <badreddin.aboubakr@cloud.ionos.com>
# Daniel Swarbrick <daniel.swarbrick@cloud.ionos.com>
# Author: Badreddin Aboubakr <[email protected]>
# Daniel Swarbrick <[email protected]>

@@ -0,0 +1,66 @@
#!/bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to standardize on /usr/bin/env ... shebangs for better portability.

Suggested change
#!/bin/sh
#!/usr/bin/env sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants