Add dmidecode exporter #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 26, 2020 14:16
Signed-off-by: Nuno Tavares <[email protected]>
Signed-off-by: Nuno Tavares <[email protected]>
Signed-off-by: Nuno Tavares <[email protected]>
|
It's been a while, I've rebased against latest master. |
SuperQ
reviewed
Dec 26, 2020
There was a problem hiding this comment.
I wonder if it would be worth it to use an existing dmidecode library like https://pypi.org/project/py-dmidecode/
| for cpu in _get('processor'): | ||
| l = _get_labels(cpu, ['Manufacturer','Family', 'Max Speed', 'Core Count'], ['Not Specified']) | ||
| l['index'] = idx | ||
| print ('node_dmi_processor{{{}}} 1'.format( ','.join('{}="{}"'.format(k,v) for k,v in l.items()) )) |
There was a problem hiding this comment.
Since these are all info metrics, they should have consistent _info in the names.
|
|
||
| system = _get('system')[0] | ||
| l = _get_labels(system, ['Manufacturer','Product Name', 'Serial Number'], ['Not Specified']) | ||
| print ('node_dmi_hardware_info{{{}}} 1'.format( ','.join('{}="{}"'.format(k,v) for k,v in l.items()) )) |
There was a problem hiding this comment.
I would call this node_dmi_system_info to match the DMI naming.
Comment on lines
+89
to
+92
| # if os.isatty(sys.stdin.fileno()): | ||
| # content = _get_output() | ||
| # else: | ||
| # content = sys.stdin.read() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a script which will generate prometheus metrics from dmidecode output.
Based on https://github.com/huanghao/dmidecode (thanks, was a nice start!)
It was created with "hardware inventory on prometheus" in mind, but can be used to track hardware changes, like failed DIMMs disappearing..