pacman: Fix script failure for no updates #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no updates are available, checkupdates and pacman -Qu fail. Catch this by wrapping the command using || true. Signed-off-by: Justus Rossmeier <[email protected]>
hansmi
reviewed
Jan 5, 2021
| @@ -14,10 +14,10 @@ set -o pipefail | |||
|
|
|||
| if [ -x /usr/bin/checkupdates ] | |||
| then | |||
| updates=$(/usr/bin/checkupdates | wc -l) | |||
| updates=$( (checkupdates || true) | wc -l) | |||
There was a problem hiding this comment.
|| true ignores all failures. As-is it would even pick another checkupdates executable if found in $PATH. Isn't there a specific exit code? If need be the output can also be checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no updates are available, checkupdates fails with exit code 2. Catch this by wrapping the command using || true.