lvm-prom-collector: Fix text format error #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following error:
For deactivated thin LVs, the
data_percent
field is empty, which causes the script to emit a metric without a value.This handles this case by simply not emitting
node_lvm_thin_pools_allocated
ifdata_percent
is empty.Another approach could be to filter out inactive LVs, like this:
However this works just fine and is probably easier to understand.
/cc @badrabubker