Record table only size bytes as well in addition to the total size bytes #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Yuan <[email protected]>
Sticksman
force-pushed
the
only-table-size-bytes
branch
from
96099cb to
4bb84e9
Compare
SuperQ
reviewed
Apr 10, 2025
Comment on lines
+189
to
+190
| pg_total_relation_size(relid) as total_size, | ||
| pg_table_size(relid) as table_only_size |
There was a problem hiding this comment.
Hmm, I wonder if we should refactor this.
From the docs.
pg_total_relation_size accepts the OID or name of a table or toast table, and returns the total on-disk space used for that table, including all associated indexes. This function is equivalent to pg_table_size + pg_indexes_size.
Instead of exposing the pg_total_relation_size, we expose the two underlying metrics and let the users sum up the values themselves.
Suggested change
| pg_total_relation_size(relid) as total_size, | |
| pg_table_size(relid) as table_only_size | |
| pg_indexes_size(relid) as indexes_size, | |
| pg_table_size(relid) as table_size |
SuperQ
reviewed
Apr 10, 2025
| @@ -156,6 +156,12 @@ var ( | |||
| []string{"datname", "schemaname", "relname"}, | |||
| prometheus.Labels{}, | |||
| ) | |||
| statUserTablesOnlySize = prometheus.NewDesc( | |||
| prometheus.BuildFQName(namespace, userTableSubsystem, "only_size_bytes"), | |||
There was a problem hiding this comment.
Suggested change
| prometheus.BuildFQName(namespace, userTableSubsystem, "only_size_bytes"), | |
| prometheus.BuildFQName(namespace, userTableSubsystem, "table_size_bytes"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg_total_relation_size gets the size of the relation + indexes and toast, however we need to know just the size of the table itself. You can get this info from pg_table_size. Should be safe to add, this function was added back in 2010.