Skip to content

feat: use slog and add debuging logs#346

Open
yuvaldekel wants to merge 39 commits intoprometheus-community:mainfrom
yuvaldekel:add-logging
Open

feat: use slog and add debuging logs#346
yuvaldekel wants to merge 39 commits intoprometheus-community:mainfrom
yuvaldekel:add-logging

Conversation

@yuvaldekel
Copy link
Copy Markdown
Contributor

@yuvaldekel yuvaldekel commented Mar 16, 2026

This PR introduces comprehensive debug logging to prom-label-proxy to make it easier to troubleshoot query enforcement, label extraction, and PromQL parsing issues. the debugging use the slog package and go by prometheus standards.
The PR Introduce two new flags log.level and log.format. Use --help to view their usage.
The PR resolve #336 issue.

yuvaldekel and others added 14 commits March 16, 2026 23:01
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@squat
Copy link
Copy Markdown
Member

squat commented Mar 17, 2026

@yuvaldekel introducing structure logging sounds good to me. My main concern here is the use of the klog package specifically: we try to stay as close to upstream Prometheus tooling wherever possible, the the Prometheus project has standardized on the upstream Golang stdlib log/slog; could you switch this PR to use log/slog instead? If so, then it would be easier to merge this.

yuvaldekel and others added 2 commits March 20, 2026 16:25
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
yuvaldekel and others added 6 commits March 20, 2026 16:45
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel yuvaldekel changed the title feat: switch to klog and add debug logs feat: use slog and add debuging logs Mar 21, 2026
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
yuvaldekel and others added 8 commits March 21, 2026 00:46
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
Signed-off-by: Yuval Dekel <yuvddd05@gmail.com>
@yuvaldekel
Copy link
Copy Markdown
Contributor Author

@yuvaldekel introducing structure logging sounds good to me. My main concern here is the use of the klog package specifically: we try to stay as close to upstream Prometheus tooling wherever possible, the the Prometheus project has standardized on the upstream Golang stdlib log/slog; could you switch this PR to use log/slog instead? If so, then it would be easier to merge this.

@squat switch to slog and added much more comprehensive debuging logs.
Hope it's good now. I whould be happy to get your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request - Add Logging

2 participants