fix: allow configuring powermode check to work better with SSDs #242
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbjorklin
force-pushed
the
introduce-powermode-check-override
branch
from
e80b26f to
b442301
Compare
rbjorklin
added a commit
to rbjorklin/helm-charts
that referenced
this pull request
Sep 9, 2024
Requires: prometheus-community/smartctl_exporter/pull/242 Signed-off-by: Robin Björklin <robin.bjorklin@gmail.com>
rbjorklin
added a commit
to rbjorklin/helm-charts
that referenced
this pull request
Sep 9, 2024
Requires: prometheus-community/smartctl_exporter/pull/242 Signed-off-by: Robin Björklin <robin.bjorklin@gmail.com>
rbjorklin
added a commit
to rbjorklin/helm-charts
that referenced
this pull request
Sep 9, 2024
Requires: prometheus-community/smartctl_exporter#242 Signed-off-by: Robin Björklin <robin.bjorklin@gmail.com>
SuperQ
requested changes
Nov 8, 2024
|
I hope one would fix & merge this pr. 🙏 I've got the same issue with a USB drive. Fixed it by adding a UDEV rule: |
rbjorklin
force-pushed
the
introduce-powermode-check-override
branch
from
7abdde5 to
34b085a
Compare
fixes prometheus-community#91 Signed-off-by: Robin Björklin <robin.bjorklin@gmail.com>
rbjorklin
force-pushed
the
introduce-powermode-check-override
branch
from
34b085a to
9bf4ec8
Compare
@SuperQ I'm not sure what you had in mind but does this work for you? |
|
Fixes #287 |
|
@NiceGuyIT could I bother you to review and merge this? |
|
@rbjorklin Done! Thanks for the nudge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting
--nocheck=neverI can correctly scrape SMART metrics from SSDs that report astandbypower state:# hdparm -C /dev/sda /dev/sda: drive state is: standbyfixes #91