Skip to content

feat(stackdriver_exporter): Add ErrorLogger for promhttp #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2024
Merged

feat(stackdriver_exporter): Add ErrorLogger for promhttp #277

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40aab90
feat(stackdriver_exporter): Add ErrorLogger for promhttp
Pokom Nov 3, 2023
fe9a710
Use level.Info(...) instead of directly calling logger
Pokom Mar 18, 2024
2bea4c5
Simplify options to use stdlog interface
Pokom Jun 3, 2024
0e4f42d
Remove unused flag from readme
Pokom Jun 3, 2024
9bb10a7
Undo formatting changes to README table
Pokom Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions stackdriver_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ package main

import (
"fmt"
stdlog "log"
"net/http"
"os"
"strings"
Expand Down Expand Up @@ -234,9 +235,9 @@ func (h *handler) innerHandler(filters map[string]bool) http.Handler {
registry,
}
}

opts := promhttp.HandlerOpts{ErrorLog: stdlog.New(log.NewStdlibAdapter(level.Error(h.logger)), "", 0)}
// Delegate http serving to Prometheus client library, which will call collector.Collect.
return promhttp.HandlerFor(gatherers, promhttp.HandlerOpts{})
return promhttp.HandlerFor(gatherers, opts)
}

// filterMetricTypePrefixes filters the initial list of metric type prefixes, with the ones coming from an individual
Expand Down