-
Notifications
You must be signed in to change notification settings - Fork 107
add system metadata labels #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add system metadata labels #416
Conversation
2d12d2c
to
03d92bf
Compare
Signed-off-by: cczhuang420 <[email protected]>
Signed-off-by: cczhuang420 <[email protected]>
03d92bf
to
f92d214
Compare
Signed-off-by: cczhuang420 <[email protected]>
Signed-off-by: cczhuang420 <[email protected]>
|
Sorry, I misunderstood this change. I think this needs more documentation and description as to why it is necessary. |
@SuperQ We also found it missing when using the project. System and user labels are part of the resources being monitored, and there's many use cases requiring filtering / grouping metrics by those types of labels. @cczhuang420 Could I ask that you also add user defined labels in this PR? As described in the API description, |
Hi folks, sorry that I couldn't manage to finish this given my current limited bandwidth, so have moved it to draft. I would need to test it more throughly before raising a PR. Feel free to close it. |
This PR is to export the system metadata labels along with metric and resource labels.