feat : Add Support for Non-Default Google Cloud Universes via a flag #429 #430
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rometheus-community#429 This commit adds a new flag, `google.universe- domain`, which allows users to specify the Google Cloud universe to use. This is useful for users who are not using the default `googleapis.com` universe. The new flag is used when creating the monitoring service, so that the service is configured to use the specified universe. Signed-off-by: Mathieu Goulin <[email protected]>
matgou
force-pushed
the
feature/429-Add-Support-for-Non-Default-Google-Cloud-Universes-via-a-flag-#429
branch
from
a3ddeb1 to
0c349f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new flag,
google.universe-domain, which allows users to specify the Google Cloud universe to use. This is useful for users who are not using the defaultgoogleapis.comuniverse.The new flag is used when creating the monitoring service, so that the service is configured to use the specified universe.