Skip to content

Speed up build metric name. #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeschkies
Copy link
Contributor

@jeschkies jeschkies commented Apr 7, 2025

› benchstat before.log after.log 
goos: linux
goarch: amd64
pkg: github.com/prometheus-community/yet-another-cloudwatch-exporter/pkg/promutil
cpu: AMD Ryzen 7 3700X 8-Core Processor             
                                                                      │  before.log  │              after.log              │
                                                                      │    sec/op    │   sec/op     vs base                │
_BuildMetricName/aws_elasticache_cpuutilization_average-16              1026.0n ± 1%   653.2n ± 1%  -36.34% (p=0.000 n=10)
_BuildMetricName/aws_sagemaker_trainingjobs_cpuutilization_average-16   1157.5n ± 2%   737.8n ± 2%  -36.26% (p=0.000 n=10)
_BuildMetricName/aws_glue_driver_aggregate_bytes_read_average-16        1040.5n ± 1%   624.2n ± 1%  -40.01% (p=0.000 n=10)
_BuildMetricName/aws_glue_aggregate_glue_jobs_bytes_read_average-16     1013.5n ± 1%   600.4n ± 2%  -40.76% (p=0.000 n=10)
geomean                                                                  1.058µ        651.9n       -38.38%

@jeschkies jeschkies force-pushed the karsten/build-metric-name branch 3 times, most recently from 7effcd1 to c9c78cd Compare April 7, 2025 13:19
@jeschkies jeschkies force-pushed the karsten/build-metric-name branch 2 times, most recently from 410d247 to dd4fac5 Compare April 9, 2025 13:33
Signed-off-by: Karsten Jeschkies <[email protected]>
@jeschkies jeschkies force-pushed the karsten/build-metric-name branch from dd4fac5 to 7b3f6d1 Compare April 10, 2025 10:51
@jeschkies jeschkies requested a review from cristiangreco April 10, 2025 10:52
@cristiangreco cristiangreco merged commit b7145de into prometheus-community:master Apr 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants